EZP-29101: Implement permissions for Content Types #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikadamczyk
requested review from
adamwojs,
sunpietro,
Nattfarinn,
webhdx,
dew326 and
ViniTou
adamwojs
approved these changes
Jun 28, 2018
ViniTou
approved these changes
Jun 28, 2018
sunpietro
suggested changes
Jun 29, 2018
| title="{{ 'content_type_group.view.list.action.edit'|trans|desc('Edit') }}" | ||
| href="{{ edit_url }}" | ||
| class="btn btn-icon mx-3"> | ||
| <svg class="ez-icon ez-icon-edit"> |
There was a problem hiding this comment.
You can remove the ez-icon-edit class name. It's not defined anywhere in CSS.
There was a problem hiding this comment.
@sunpietro fixed
sunpietro
reviewed
Jun 29, 2018
| title="{{ 'content_type.view.list.action.add'|trans|desc('Create a Content Type') }}" | ||
| class="btn btn-primary"> | ||
| <svg class="ez-icon ez-icon-create"> | ||
| <use xmlns:xlink="http://www.w3.org/1999/xlink" |
There was a problem hiding this comment.
This part: xmlns:xlink="http://www.w3.org/1999/xlink" is not needed at all.
There was a problem hiding this comment.
Please, fix it in other places as well
There was a problem hiding this comment.
@sunpietro fixed. As we discussed I will make another PR for other places.
sunpietro
approved these changes
Jun 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
$ composer fix-cs)